From 454ed0032b45e391fd3803ec3b6dee682db77e36 Mon Sep 17 00:00:00 2001
From: verysecrethero <hnorthh@gmail.com>
Date: Tue, 15 Dec 2015 14:01:49 +0100
Subject: [PATCH] Refactored some RayVsModel tests

---
 src/Tests/CollisionTest.cpp | 77 ++++++++++---------------------------
 1 file changed, 21 insertions(+), 56 deletions(-)

diff --git a/src/Tests/CollisionTest.cpp b/src/Tests/CollisionTest.cpp
index eb048a79..82e2e800 100644
--- a/src/Tests/CollisionTest.cpp
+++ b/src/Tests/CollisionTest.cpp
@@ -10,6 +10,7 @@ using boost::unit_test_framework::test_case;
 #include "Engine/Core/OctTree.h"
 //vs model
 #include <sstream>
+#include <string>
 
 //ray vs model
 #include "Engine\Core\ResourceManager.h"
@@ -23,6 +24,22 @@ using boost::unit_test_framework::test_case;
 //#define DEBUG_CLIENTBLOCK new( _CLIENT_BLOCK, __FILE__, __LINE__)
 //#define new DEBUG_CLIENTBLOCK
 
+void RayTest(std::string fileName) {
+    //simple box test
+    Ray ray;
+    ray.Origin = glm::vec3(-50, 0, 0);
+    ray.Direction = glm::normalize(glm::vec3(1, 0, 0));
+    //using a rawmodel here, else we have to init the renderingsystem
+    ResourceManager::RegisterType<RawModel>("RawModel");
+    auto unitBox = ResourceManager::Load<RawModel>(fileName);
+    BOOST_CHECK(unitBox != nullptr);
+    bool hit = Collision::RayVsModel(ray, unitBox->m_Vertices, unitBox->m_Indices);
+    BOOST_CHECK(hit);
+    ray.Direction = glm::normalize(glm::vec3(-1, 0, 0));
+    hit = Collision::RayVsModel(ray, unitBox->m_Vertices, unitBox->m_Indices);
+    BOOST_CHECK(!hit);
+}
+
 BOOST_AUTO_TEST_SUITE(collisionTests)
 
 BOOST_AUTO_TEST_CASE(collisionTest)
@@ -97,19 +114,7 @@ BOOST_AUTO_TEST_CASE(collisionTest2)
 BOOST_AUTO_TEST_CASE(rayVsModelTest)
 {
     //simple box test
-
-    Ray ray;
-    ray.Origin = glm::vec3(-50, 0, 0);
-    ray.Direction = glm::normalize(glm::vec3(1, 0, 0));
-    //using a rawmodel here, else we have to init the renderingsystem
-    ResourceManager::RegisterType<RawModel>("RawModel");
-    auto unitBox = ResourceManager::Load<RawModel>("Models/Core/UnitBox.obj");
-    BOOST_CHECK(unitBox != nullptr);
-    bool hit = Collision::RayVsModel(ray, unitBox->m_Vertices, unitBox->m_Indices);
-    BOOST_CHECK(hit);
-    ray.Direction = glm::normalize(glm::vec3(-1, 0, 0));
-    hit = Collision::RayVsModel(ray, unitBox->m_Vertices, unitBox->m_Indices);
-    BOOST_CHECK(!hit);
+    RayTest("Models/Core/UnitBox.obj");
 }
 
 BOOST_AUTO_TEST_CASE(rayVsModelTest2)
@@ -194,62 +199,22 @@ BOOST_AUTO_TEST_CASE(rayVsModelTest2)
 
     }
 }
-
 BOOST_AUTO_TEST_CASE(rayVsModelTest3)
 {
     //simple test
-
-    Ray ray;
-    ray.Origin = glm::vec3(-50, 0, 0);
-    //ray.Direction = glm::vec3(-1, 0, 0);
-    ray.Direction = glm::normalize(glm::vec3(1, 0, 0));
-    //using a rawmodel here, else we have to init the renderingsystem
-    ResourceManager::RegisterType<RawModel>("RawModel");
-    auto unitBox = ResourceManager::Load<RawModel>("Models/Core/UnitSphere.obj");
-    BOOST_CHECK(unitBox != nullptr);
-    bool hit = Collision::RayVsModel(ray, unitBox->m_Vertices, unitBox->m_Indices);
-    BOOST_CHECK(hit);
-    ray.Direction = glm::normalize(glm::vec3(-1, 0, 0));
-    hit = Collision::RayVsModel(ray, unitBox->m_Vertices, unitBox->m_Indices);
-    BOOST_CHECK(!hit);
+    RayTest("Models/Core/UnitSphere.obj");
 }
 
 BOOST_AUTO_TEST_CASE(rayVsModelTest4)
 {
     //simple test
-
-    Ray ray;
-    ray.Origin = glm::vec3(-50, 0, 0);
-    //ray.Direction = glm::vec3(-1, 0, 0);
-    ray.Direction = glm::normalize(glm::vec3(1, 0, 0));
-    //using a rawmodel here, else we have to init the renderingsystem
-    ResourceManager::RegisterType<RawModel>("RawModel");
-    auto unitBox = ResourceManager::Load<RawModel>("Models/Core/UnitCylinder.obj");
-    BOOST_CHECK(unitBox != nullptr);
-    bool hit = Collision::RayVsModel(ray, unitBox->m_Vertices, unitBox->m_Indices);
-    BOOST_CHECK(hit);
-    ray.Direction = glm::normalize(glm::vec3(-1, 0, 0));
-    hit = Collision::RayVsModel(ray, unitBox->m_Vertices, unitBox->m_Indices);
-    BOOST_CHECK(!hit);
+    RayTest("Models/Core/UnitCylinder.obj");
 }
 
 BOOST_AUTO_TEST_CASE(rayVsModelTest5)
 {
     //simple test
-
-    Ray ray;
-    ray.Origin = glm::vec3(-50, 0, 0);
-    //ray.Direction = glm::vec3(-1, 0, 0);
-    ray.Direction = glm::normalize(glm::vec3(1, 0, 0));
-    //using a rawmodel here, else we have to init the renderingsystem
-    ResourceManager::RegisterType<RawModel>("RawModel");
-    auto unitBox = ResourceManager::Load<RawModel>("Models/Core/UnitRaptor.obj");
-    BOOST_CHECK(unitBox != nullptr);
-    bool hit = Collision::RayVsModel(ray, unitBox->m_Vertices, unitBox->m_Indices);
-    BOOST_CHECK(hit);
-    ray.Direction = glm::normalize(glm::vec3(-1, 0, 0));
-    hit = Collision::RayVsModel(ray, unitBox->m_Vertices, unitBox->m_Indices);
-    BOOST_CHECK(!hit);
+    RayTest("Models/Core/UnitRaptor.obj");
 }
 BOOST_AUTO_TEST_CASE(octTest)
 {