Proper string handling without nasty memory leaks. PHEW.
This commit is contained in:
@@ -2,6 +2,7 @@
|
||||
#define ComponentInfo_h__
|
||||
|
||||
#include "../Common.h"
|
||||
#include <boost/shared_array.hpp>
|
||||
|
||||
struct ComponentInfo
|
||||
{
|
||||
@@ -29,7 +30,7 @@ struct ComponentInfo
|
||||
std::vector<std::string> FieldsInOrder;
|
||||
std::vector<std::string> StringFields;
|
||||
unsigned int Stride = 0;
|
||||
std::shared_ptr<char> Defaults = nullptr;
|
||||
boost::shared_array<char> Defaults = nullptr;
|
||||
std::shared_ptr<Meta_t> Meta = nullptr;
|
||||
};
|
||||
|
||||
|
||||
@@ -2,6 +2,7 @@
|
||||
#define ComponentWrapper_h__
|
||||
|
||||
#include <boost/shared_array.hpp>
|
||||
#include <boost/any.hpp>
|
||||
#include "../Common.h"
|
||||
#include "Entity.h"
|
||||
#include "ComponentInfo.h"
|
||||
@@ -75,10 +76,21 @@ struct ComponentWrapper
|
||||
{
|
||||
for (auto& name : component.Info.StringFields) {
|
||||
std::size_t offset = component.Info.Fields.at(name).Offset;
|
||||
auto& value = *reinterpret_cast<const std::string*>(component.Data + offset);
|
||||
std::string value = *reinterpret_cast<const std::string*>(component.Data + offset);
|
||||
new (component.Data + offset) std::string(value);
|
||||
}
|
||||
}
|
||||
|
||||
// This needs to be called to properly free component data, because strings.
|
||||
static void Destroy(ComponentInfo info, char* data)
|
||||
{
|
||||
// Call std::string destructors
|
||||
for (auto& name : info.StringFields) {
|
||||
std::size_t offset = info.Fields.at(name).Offset;
|
||||
auto field = reinterpret_cast<std::string*>(data + offset);
|
||||
field->~basic_string();
|
||||
}
|
||||
}
|
||||
|
||||
struct SubscriptProxy
|
||||
{
|
||||
@@ -124,4 +136,56 @@ private:
|
||||
boost::shared_array<char> m_DataReference;
|
||||
};
|
||||
|
||||
// TODO: Move this to Tests once entity importing is finished
|
||||
class ComponentWrapperFactory
|
||||
{
|
||||
public:
|
||||
ComponentWrapperFactory() = default;
|
||||
ComponentWrapperFactory(std::string componentTypeName, unsigned int allocation = 0)
|
||||
{
|
||||
m_ComponentInfo.Name = componentTypeName;
|
||||
m_ComponentInfo.Meta = std::make_shared<ComponentInfo::Meta_t>();
|
||||
m_ComponentInfo.Meta->Allocation = allocation;
|
||||
}
|
||||
|
||||
template <typename T>
|
||||
void AddProperty(std::string fieldName, T defaultValue)
|
||||
{
|
||||
auto& field = m_ComponentInfo.Fields[fieldName];
|
||||
field.Name = fieldName;
|
||||
field.Type = typeid(T).name();
|
||||
field.Offset = m_ComponentInfo.Stride;
|
||||
field.Stride = sizeof(T);
|
||||
m_ComponentInfo.FieldsInOrder.push_back(field.Name);
|
||||
if (field.Type == typeid(std::string).name()) {
|
||||
field.Type = "string";
|
||||
m_ComponentInfo.StringFields.push_back(field.Name);
|
||||
}
|
||||
m_ComponentInfo.Stride += sizeof(T);
|
||||
m_DefaultValues.push_back(std::make_pair(field, defaultValue));
|
||||
}
|
||||
|
||||
ComponentInfo& Finalize()
|
||||
{
|
||||
m_ComponentInfo.Defaults = boost::shared_array<char>(new char[m_ComponentInfo.Stride]);
|
||||
std::size_t offset = 0;
|
||||
for (auto& pair : m_DefaultValues) {
|
||||
if (pair.first.Type == "string") {
|
||||
new (m_ComponentInfo.Defaults.get() + offset) std::string(*reinterpret_cast<std::string*>(pair.second.Data.get()));
|
||||
} else {
|
||||
memcpy(m_ComponentInfo.Defaults.get() + offset, pair.second.Data.get(), pair.second.Size);
|
||||
}
|
||||
offset += pair.second.Size;
|
||||
}
|
||||
|
||||
return m_ComponentInfo;
|
||||
}
|
||||
|
||||
operator ComponentInfo&() { return Finalize(); }
|
||||
|
||||
private:
|
||||
ComponentInfo m_ComponentInfo;
|
||||
std::vector<std::pair<ComponentInfo::Field_t, Any>> m_DefaultValues;
|
||||
};
|
||||
|
||||
#endif
|
||||
|
||||
@@ -68,12 +68,13 @@ public:
|
||||
|
||||
MemoryPool(const MemoryPool<T>& other)
|
||||
: m_StartAddress(new char[other.m_NumSlots*other.m_Stride])
|
||||
, m_SlotIsAllocated(other.m_NumSlots, false)
|
||||
, m_SlotIsAllocated(other.m_SlotIsAllocated)
|
||||
, m_ExtraMemory()
|
||||
, m_NumSlots(other.m_NumSlots)
|
||||
, m_LowestAllocatedSlot(other.m_LowestAllocatedSlot)
|
||||
, m_NumAllocatedSlots(other.m_NumAllocatedSlots)
|
||||
, m_Stride(other.m_Stride)
|
||||
, m_NumAllocatedSlots(0)
|
||||
, m_CurrentAllocSlot(0)
|
||||
, m_LowestAllocatedSlot(m_NumSlots)
|
||||
, m_CurrentAllocSlot(other.m_CurrentAllocSlot)
|
||||
{
|
||||
// Copy statically allocated pool
|
||||
memcpy(m_StartAddress, other.m_StartAddress, m_NumSlots*m_Stride);
|
||||
@@ -93,8 +94,9 @@ public:
|
||||
delete[] m_StartAddress;
|
||||
m_StartAddress = nullptr;
|
||||
}
|
||||
for (char* addr : m_ExtraMemory)
|
||||
free(addr);
|
||||
for (char* addr : m_ExtraMemory) {
|
||||
free(addr);
|
||||
}
|
||||
m_ExtraMemory.clear();
|
||||
}
|
||||
|
||||
|
||||
@@ -2,6 +2,7 @@
|
||||
#define Util_Any_h__
|
||||
|
||||
#include <memory>
|
||||
#include <boost/shared_array.hpp>
|
||||
|
||||
struct Any
|
||||
{
|
||||
@@ -10,7 +11,7 @@ struct Any
|
||||
template <typename T>
|
||||
Any(const T& value)
|
||||
{
|
||||
Data = std::shared_ptr<char>(new char[sizeof(T)]);
|
||||
Data = boost::shared_array<char>(new char[sizeof(T)]);
|
||||
Size = sizeof(T);
|
||||
memcpy(Data.get(), &value, Size);
|
||||
}
|
||||
@@ -18,7 +19,7 @@ struct Any
|
||||
template <typename T>
|
||||
Any(T&& value)
|
||||
{
|
||||
Data = std::shared_ptr<char>(new char[sizeof(T)]);
|
||||
Data = boost::shared_array<char>(new char[sizeof(T)]);
|
||||
Size = sizeof(T);
|
||||
memcpy(Data.get(), &value, Size);
|
||||
}
|
||||
@@ -35,7 +36,7 @@ struct Any
|
||||
return Any(value);
|
||||
}
|
||||
|
||||
std::shared_ptr<char> Data = nullptr;
|
||||
boost::shared_array<char> Data = nullptr;
|
||||
std::size_t Size = 0;
|
||||
};
|
||||
|
||||
|
||||
Reference in New Issue
Block a user