Makes sure m_CurrentSelection is valid before using it.

include/Engine/Editor/EditorSystem.h

@@ -47,6 +47,7 @@ private:
     // Utility functions
     EntityWrapper importEntity(EntityWrapper parent, boost::filesystem::path filePath);
     void setWidgetMode(EditorGUI::WidgetMode mode);
+    bool isAnyParentMissingTransform(EntityID entityID);
 
     // GUI callbacks
     void OnEntitySelected(EntityWrapper entity);

include/Engine/Network/Client.h

@@ -42,7 +42,7 @@ public:
     void Connect(std::string address, int port);
     void Update() override;
 private:
-    UDPClient m_Unreliable;
+    //UDPClient m_Unreliable;
     TCPClient m_Reliable;
     std::vector<Events::PlayerSpawned> m_PlayerSpawnEvents;
     void parseSpawnEvents();
@@ -81,7 +81,7 @@ private:
     std::vector<Events::InputCommand> m_InputCommandBuffer;
 
     // Private member functions
-    size_t receive(char* data);
+    size_t  receive(char* data);
     void disconnect();
     void parseMessageType(Packet& packet);
     void updateFields(Packet& packet, const ComponentInfo& componentInfo, const EntityID& entityID);
@@ -139,7 +139,7 @@ private:
     std::vector<ServerInfo> m_Serverlist;
     bool m_SearchingForServers = false;
     std::clock_t m_StartSearchTime;
-    double m_SearchingTime = 200; // Config I guess
+    double m_SearchingTime = 2000; // Config I guess
 };
 
 #endif

include/Engine/Network/Network.h

@@ -39,7 +39,6 @@ protected:
     void logReceivedData(int bytesReceived);
     void saveToFile();
     void updateNetworkData();
-    void popNetworkSegmentOfHeader(Packet& packet);
 };
 
 #endif

include/Engine/Network/Packet.h

@@ -16,9 +16,7 @@ public:
     Packet(char* data, const size_t sizeOfPacket);
     Packet(MessageType type);
     ~Packet();
-    void Init(MessageType type, unsigned int& packetID,
-        int groupIndex, int groupSize,
-        int packetGroup);
+    void Init(MessageType type, unsigned int& packetID);
 
     // Add primitive types like int, float, char...
     template<typename T>
@@ -27,8 +25,7 @@ public:
         // Check if we are trying to add more than the package can fit.
         if (m_MaxPacketSize < m_Offset + sizeof(T)) {
             if (m_MaxPacketSize >= 32000) {
-                // This will spam couse 8 players are over 100 000 bytes
-                //LOG_WARNING("Package::WritePrimitive(): New size is huge %i bytes\n", m_MaxPacketSize*2);
+                LOG_WARNING("Package::WritePrimitive(): New size is huge %i bytes\n", m_MaxPacketSize*2);
             }
             resizeData();
         }
@@ -60,19 +57,13 @@ public:
     void UpdateSize();
     char* ReadData(int SizeOfData);
     void ChangePacketID(unsigned int& packetID);
-    void ChangeGroupIndex(int groupIndex);
-    void ChangeGroupSize(int groupSize);
-    void ChangeGroup(int group);
     size_t Size() { return m_Offset; };
     char* Data() { return m_Data; };
     MessageType GetMessageType();
-    size_t Group();
     size_t DataReadSize() { return m_ReturnDataOffset; }
     size_t MaxSize() { return m_MaxPacketSize; }
     size_t HeaderSize() { return m_HeaderSize; }
-    size_t GroupIndex();
-    size_t GroupSize();
-    size_t PacketID();
+
 private:
     char* m_Data;
     size_t m_ReturnDataOffset = 0;
@@ -81,13 +72,6 @@ private:
     size_t m_HeaderSize = 0;
     void resizeData();
     void resizeData(int size);
-
-    size_t packetSizeOffset = 0;
-    size_t groupOffset = 0;
-    size_t groupIndexOffset = 0;
-    size_t groupSizeOffset = 0;
-    size_t messageTypeOffset = 0;
-    size_t packetIDOffset = 0;
 };
 
 #endif

include/Engine/Network/PlayerDefinition.h

@@ -14,7 +14,6 @@ struct PlayerDefinition {
     unsigned short TCPPort;
     // use for tcp connections
     boost::shared_ptr<boost::asio::ip::tcp::socket> TCPSocket;
-    int PacketGroup = 1;
 };
 
 #endif

include/Engine/Network/Server.h

@@ -36,7 +36,7 @@ public:
 private:
     // Network channels
     TCPServer m_Reliable;
-    UDPServer m_Unreliable;
+    //UDPServer m_Unreliable;
     UDPServer m_ServerlistRequest;
     // dont forget to set these in the childrens receive logic
     boost::asio::ip::address m_Address;

include/Engine/Network/UDPClient.h

@@ -1,7 +1,5 @@
 #ifndef UDPClient_h__
 #define UDPClient_h__
-#include <map>
-#include <algorithm>
 
 #include <boost/asio.hpp>
 #include "Network/NetworkClient.h"
@@ -15,27 +13,16 @@ public:
     bool Connect(std::string playerName, std::string address, int port);
     void Disconnect();
     void Receive(Packet& packet);
-    void ReceivePackets();
-    void Send(Packet& packet);
+    void Send(Packet & packet);
     void Broadcast(Packet& packet, int port);
     bool IsSocketAvailable();
-    // Returns false if no packets are available
-    bool GetNextPacket(Packet& packet);
 private:
-    typedef std::map<unsigned int, std::vector<std::pair<int, boost::shared_ptr<char>>>> PacketMap;
     // Assio UDP logic
     boost::asio::io_service m_IOService;
     boost::asio::ip::udp::endpoint m_ReceiverEndpoint;
     boost::shared_ptr<boost::asio::ip::udp::socket> m_Socket;
-    int m_LastReceivedSnapshotGroup = 0;
     int readBuffer();
-    void readPartOfPacket();
     PacketID m_SendPacketID = 0;
-    //map:(packetGroup, vector:(pair:(groupIndex, packetData)))
-    PacketMap m_PacketSegmentMap;
-    bool hasReceivedPacket(int packetGroup, int groupIndex);
-    // 2^19
-    const int m_SizeOfSocketBuffer = 524288;
 };
 
 #endif

include/Engine/Network/UDPServer.h

@@ -3,7 +3,6 @@
 
 #include "NetworkServer.h"
 #include <boost/asio/ip/udp.hpp>
-#define MAXPACKETSIZE 64000
 
 class UDPServer : public NetworkServer
 {
@@ -14,7 +13,6 @@ public:
     void AcceptNewConnections(int& nextPlayerID, std::map<PlayerID, PlayerDefinition>& connectedPlayers);
     void Receive(Packet & packet, PlayerDefinition & playerDefinition);
     void Send(Packet & packet, PlayerDefinition & playerDefinition);
-    void SendToConnectedPlayers(Packet & packet, std::map<PlayerID, PlayerDefinition>& playersTosendTo);
     void Send(Packet & packet); 
     void Send(Packet & packet, boost::asio::ip::udp::endpoint endpoint);
     void Broadcast(Packet & packet, int port);

src/Engine/Editor/EditorSystem.cpp

@@ -4,7 +4,7 @@
 #include "Editor/EditorWidgetSystem.h"
 #include "Core/EntityFile.h"
 
-EditorSystem::EditorSystem(SystemParams params, IRenderer* renderer, RenderFrame* renderFrame) 
+EditorSystem::EditorSystem(SystemParams params, IRenderer* renderer, RenderFrame* renderFrame)
     : System(params)
     , m_Renderer(renderer)
     , m_RenderFrame(renderFrame)
@@ -14,7 +14,7 @@ EditorSystem::EditorSystem(SystemParams params, IRenderer* renderer, RenderFrame
     m_EditorWorldSystemPipeline->AddSystem<UniformScaleSystem>(0);
     m_EditorWorldSystemPipeline->AddSystem<EditorWidgetSystem>(0, m_Renderer);
     m_EditorWorldSystemPipeline->AddSystem<EditorRenderSystem>(1, m_Renderer, m_RenderFrame);
-    
+
     m_EditorCamera = importEntity(EntityWrapper(m_EditorWorld, EntityID_Invalid), "Schema/Entities/Empty.xml");
     m_ActualCamera = m_EditorCamera;
     m_EditorWorld->AttachComponent(m_EditorCamera.ID, "Transform");
@@ -72,6 +72,9 @@ void EditorSystem::Update(double dt)
         m_EditorStats->Draw(actualDelta);
 
         if (m_CurrentSelection.Valid() && m_Widget.Valid()) {
+            if (isAnyParentMissingTransform(m_CurrentSelection.ID)) {
+                return;
+            }
             (glm::vec3&)m_Widget["Transform"]["Position"] = Transform::AbsolutePosition(m_CurrentSelection);
             if (m_WidgetSpace == EditorGUI::WidgetSpace::Local) {
                 (glm::vec3&)m_Widget["Transform"]["Orientation"] = Transform::AbsoluteOrientationEuler(m_CurrentSelection);
@@ -79,7 +82,6 @@ void EditorSystem::Update(double dt)
                 (glm::vec3&)m_Widget["Transform"]["Orientation"] = glm::vec3(0, 0, 0);
             }
         }
-
         m_EditorWorldSystemPipeline->Update(actualDelta);
 
         ComponentWrapper& cameraTransform = m_EditorCamera["Transform"];
@@ -203,6 +205,9 @@ bool EditorSystem::OnMousePress(const Events::MousePress& e)
 bool EditorSystem::OnWidgetDelta(const Events::WidgetDelta& e)
 {
     if (m_CurrentSelection.Valid()) {
+        if (isAnyParentMissingTransform(m_CurrentSelection.ID)) {
+            return false;
+        }
         if (m_WidgetSpace == EditorGUI::WidgetSpace::Global) {
             glm::quat parentOrientation;
             glm::vec3 parentScale(1.f);
@@ -309,3 +314,15 @@ void EditorSystem::setWidgetMode(EditorGUI::WidgetMode mode)
 
     m_Widget["Transform"]["Position"] = Transform::AbsolutePosition(m_CurrentSelection.World, m_CurrentSelection.ID);
 }
+
+bool EditorSystem::isAnyParentMissingTransform(EntityID entityID)
+{
+    EntityWrapper entity(m_World, entityID);
+    while (entity.Parent().Valid()) {
+        if (!entity.HasComponent("Transform")) {
+            return true;
+        }
+        entity = entity.Parent();
+    }
+    return false;
+}

src/Engine/Network/Client.cpp

@@ -51,19 +51,16 @@ void Client::Connect(std::string address, int port)
 void Client::Update()
 {
     m_EventBroker->Process<Client>();
-    while (m_Unreliable.IsSocketAvailable()) {
-        m_Unreliable.ReceivePackets();
-    }
-    // Packet will get real data in GetNextPacket()
-    Packet parsedPacket(MessageType::Invalid);
-    while (m_Unreliable.GetNextPacket(parsedPacket)) {
-        if (parsedPacket.GetMessageType() == MessageType::Connect) {
-            parseUDPConnect(parsedPacket);
-        } else {
-            parseMessageType(parsedPacket);
-        }
-    }
-
+    //while (m_Unreliable.IsSocketAvailable()) {
+    //    // Packet will get real data in receive
+    //    Packet packet(MessageType::Invalid);
+    //    m_Unreliable.Receive(packet);
+    //    if (packet.GetMessageType() == MessageType::Connect) {
+    //        parseUDPConnect(packet);
+    //    } else {
+    //        parseMessageType(packet);
+    //    }
+    //}
     while (m_Reliable.IsSocketAvailable()) {
         // Packet will get real data in receive
         Packet packet(MessageType::Invalid);
@@ -110,9 +107,8 @@ void Client::Update()
 
 void Client::parseMessageType(Packet& packet)
 {
-    // Pop packetSize, sequenceNumber and packetsInSequence.
-    popNetworkSegmentOfHeader(packet);
-
+    // Pop packetSize
+    packet.ReadPrimitive<int>();
     int messageType = packet.ReadPrimitive<int>();
     if (messageType == -1)
         return;
@@ -167,29 +163,26 @@ void Client::parseMessageType(Packet& packet)
 void Client::parseUDPConnect(Packet& packet)
 {
     // Map ServerEntityID and your PlayerID
-    // TODO: If this is not received send a new connect message.
     LOG_INFO("I be connected PogChamp");
 }
 
 void Client::parseTCPConnect(Packet& packet)
 {
     LOG_INFO("Received TCP connect from server");
-    // Pop packetSize, group, groupIndex and groupSize.
-    popNetworkSegmentOfHeader(packet);
-
+    // Pop size of message int
+    packet.ReadPrimitive<int>();
     int messageType = packet.ReadPrimitive<int>();
     // Read packet ID 
     m_PreviousPacketID = m_PacketID;    // Set previous packet id
     m_PacketID = packet.ReadPrimitive<int>(); //Read new packet id
     // parse player id and other stuff
     m_PlayerID = packet.ReadPrimitive<int>();
+    m_PlayerID = packet.ReadPrimitive<int>();
     LOG_INFO("A Player connected");
-    // TODO: If this is not received send a new connect message.
     Packet UnreliablePacket(MessageType::Connect, m_SendPacketID);
     // Add player id and other stuff
     packet.WritePrimitive(m_PlayerID);
-    m_Unreliable.Send(packet);
-
+    //   m_Unreliable.Send(packet);
      //  LOG_INFO("Sent UDP Connect Server");
 }
 
@@ -216,11 +209,10 @@ void Client::parsePing()
 
 void Client::parseServerlist(Packet& packet)
 {
-    // Pop packetSize, group, groupIndex and groupSize.
-    popNetworkSegmentOfHeader(packet);
+    // Pop size, message type, and ID
+    packet.ReadPrimitive<int>();
     packet.ReadPrimitive<int>();
     packet.ReadPrimitive<int>();
-
     std::string address = packet.ReadString();
     int port = packet.ReadPrimitive<int>();
     std::string serverName = packet.ReadString();
@@ -472,7 +464,6 @@ void Client::disconnect()
     m_PacketID = 0;
     Packet packet(MessageType::Disconnect, m_SendPacketID);
     m_Reliable.Send(packet);
-    m_Unreliable.Disconnect();
     m_Reliable.Disconnect();
     Events::PlayerDisconnected e;
     e.Entity = m_LocalPlayer.ID;
@@ -489,8 +480,8 @@ bool Client::OnInputCommand(const Events::InputCommand & e)
 
     if (e.Command == "ConnectToServer") { // Connect for now
         if (e.Value > 0) {
-            m_Reliable.Connect(m_PlayerName, m_Address, m_Port);
-            m_Unreliable.Connect(m_PlayerName, m_Address, m_Port);
+            //m_Reliable.Connect(m_PlayerName, m_Address, m_Port);
+        //    m_Unreliable.Connect(m_PlayerName, m_Address, m_Port);
         }
         //LOG_DEBUG("Client::OnInputCommand: Command is %s. Value is %f. PlayerID is %i.", e.Command.c_str(), e.Value, e.PlayerID);
         return true;
@@ -567,7 +558,6 @@ bool Client::OnConnectRequest(const Events::ConnectRequest& e)
 {
     removeWorld();
     if (m_Reliable.Connect(m_PlayerName, e.IP, e.Port)) {
-        m_Unreliable.Connect(m_PlayerName, e.IP, e.Port);
         // The client sent a successful connect message
         return true;
 
@@ -644,7 +634,7 @@ void Client::sendLocalPlayerTransform()
         packet.WritePrimitive((int)cAssaultWeapon["Ammo"]);
     }
 
-    m_Unreliable.Send(packet);
+    m_Reliable.Send(packet);
 }
 
 void Client::identifyPacketLoss()
@@ -706,6 +696,7 @@ void Client::displayServerlist()
     }
 }
 
+
 void Client::removeWorld()
 {
     std::vector<EntityID> childrenToBeDeleted;

src/Engine/Network/Network.cpp

@@ -83,12 +83,3 @@ void Network::updateNetworkData()
         m_NetworkData.DataReceivedThisInterval = 0;
     }
 }
-
-void Network::popNetworkSegmentOfHeader(Packet & packet)
-{
-    // Pop packetSize, group, groupIndex and groupSize.
-    packet.ReadPrimitive<int>();
-    packet.ReadPrimitive<int>();
-    packet.ReadPrimitive<int>();
-    packet.ReadPrimitive<int>();
-}

src/Engine/Network/Packet.cpp

@@ -3,22 +3,16 @@
 Packet::Packet(MessageType type, unsigned int& packetID)
 {
     m_Data = new char[m_MaxPacketSize];
-    Init(type, packetID, 1, 1, -1);
+    Init(type, packetID);
 }
 
 // Create message
 Packet::Packet(char* data, const size_t sizeOfPacket)
 {
-    // Create message header
-    // allocate memory for size of packet, sequenceNumber and totalPacketesInSequence
-    m_ReturnDataOffset = 0;
-    m_Offset = 0;
     // Resize message
     m_MaxPacketSize = sizeOfPacket;
     // Copy data newly allocated memory
     m_Data = new char[sizeOfPacket];
-    unsigned int dummy = 0;
-    Init(MessageType::Invalid, dummy, 0, 0, 0);
     memcpy(m_Data, data, sizeOfPacket);
     m_Offset = sizeOfPacket;
 }
@@ -27,7 +21,7 @@ Packet::Packet(MessageType type)
 {
     m_Data = new char[m_MaxPacketSize];
     unsigned int dummy = 0;
-    Init(type, dummy, 1, 1, -1);
+    Init(type, dummy);
 }
 
 Packet::~Packet()
@@ -35,30 +29,16 @@ Packet::~Packet()
     delete[] m_Data;
 }
 
-void Packet::Init(MessageType type, unsigned int & packetID,
-    int groupIndex, int groupSize, int group)
+void Packet::Init(MessageType type, unsigned int & packetID)
 {
     m_ReturnDataOffset = 0;
     m_Offset = 0;
     // Create message header
-    // allocate memory for size of packet, sequenceNumber and totalPacketesInSequence
-    packetSizeOffset = m_Offset;
+    // allocate memory for size of packet(only used in tcp)
     WritePrimitive<int>(0);
-    // packetGroup is the group the packet is in
-    groupOffset = m_Offset;
-    WritePrimitive<int>(group);
-    // What index the packet has in the packetGroup
-    groupIndexOffset = m_Offset;
-    WritePrimitive(groupIndex);
-    // The total amount of packets in a packetGroup
-    groupSizeOffset = m_Offset;
-    WritePrimitive(groupSize);
     // Add message type
     int messageType = static_cast<int>(type);
-    messageTypeOffset = m_Offset;
     WritePrimitive<int>(messageType);
-    // Packet ID
-    packetIDOffset = m_Offset;
     WritePrimitive<int>(packetID);
     packetID++;
     m_HeaderSize = m_Offset;
@@ -124,7 +104,8 @@ void Packet::ReconstructFromData(char * data, size_t sizeOfData)
 
 void Packet::UpdateSize()
 {
-    memcpy(m_Data + packetSizeOffset, &m_Offset, sizeof(int));
+    int whatisoffset = m_Offset;
+    memcpy(m_Data, &m_Offset, sizeof(int));
 }
 
 char * Packet::ReadData(int sizeOfData)
@@ -142,47 +123,14 @@ void Packet::ChangePacketID(unsigned int & packetID)
 {
     packetID = packetID + 1;
     // Overwrite old PacketID
-    memcpy(m_Data + packetIDOffset, &packetID, sizeof(int));
-}
-
-void Packet::ChangeGroupIndex(int groupIndex)
-{
-    memcpy(m_Data + groupIndexOffset, &groupIndex, sizeof(int));
-}
-
-void Packet::ChangeGroupSize(int groupSize)
-{ 
-    memcpy(m_Data + groupSizeOffset, &groupSize, sizeof(int));
-}
-
-void Packet::ChangeGroup(int group)
-{ 
-    memcpy(m_Data + groupOffset, &group, sizeof(int));
+    memcpy(m_Data + 2*sizeof(int), &packetID, sizeof(int));
 }
 
 MessageType Packet::GetMessageType()
 {
-    return *reinterpret_cast<MessageType*>(m_Data + messageTypeOffset);
-}
-
-size_t Packet::Group()
-{
-    return *reinterpret_cast<size_t*>(m_Data + groupOffset);
-}
-
-size_t Packet::GroupIndex()
-{
-    return *reinterpret_cast<size_t*>(m_Data + groupIndexOffset);
-}
-
-size_t Packet::GroupSize()
-{
-    return *reinterpret_cast<size_t*>(m_Data + groupSizeOffset);
-}
-
-size_t Packet::PacketID()
-{
-    return *reinterpret_cast<size_t*>(m_Data + packetIDOffset);
+    MessageType messagType;
+    memcpy(&messagType, m_Data + sizeof(int), sizeof(int));
+    return messagType;
 }
 
 void Packet::resizeData()

src/Engine/Network/Server.cpp

@@ -49,19 +49,19 @@ void Server::Update()
         }
     }
 
-    PlayerDefinition pd;
-    while (m_Unreliable.IsSocketAvailable()) {
-        // Packet will get real data in receive
-        Packet packet(MessageType::Invalid);
-        m_Unreliable.Receive(packet, pd);
-        m_Address = pd.Endpoint.address();
-        m_Port = pd.Endpoint.port();
-        if (packet.GetMessageType() == MessageType::Connect) {
-            parseUDPConnect(packet);
-        } else {
-            parseMessageType(packet);
-        }
-    }
+    //PlayerDefinition pd;
+    //while (m_Unreliable.IsSocketAvailable()) {
+    //    // Packet will get real data in receive
+    //    Packet packet(MessageType::Invalid);
+    //    m_Unreliable.Receive(packet, pd);
+    //    m_Address = pd.Endpoint.address();
+    //    m_Port = pd.Endpoint.port();
+    //    if (packet.GetMessageType() == MessageType::Connect) {
+    //        parseUDPConnect(packet);
+    //    } else {
+    //        parseMessageType(packet);
+    //    }
+    //}
 
     while (m_ServerlistRequest.IsSocketAvailable()) {
         Packet packet(MessageType::Invalid);
@@ -69,11 +69,9 @@ void Server::Update()
         localArea.Endpoint = boost::asio::ip::udp::endpoint();
         m_ServerlistRequest.Receive(packet, localArea);
         if (packet.GetMessageType() == MessageType::ServerlistRequest) {
-            // Pop header
-            popNetworkSegmentOfHeader(packet);
-            packet.ReadPrimitive<int>();
-            packet.ReadPrimitive<int>();
-
+            packet.ReadPrimitive<int>(); // Pop size
+            packet.ReadPrimitive<int>(); // Pop MsgType
+            packet.ReadPrimitive<int>(); // Pop packet ID
             int port = packet.ReadPrimitive<int>();
             std::string address = localArea.Endpoint.address().to_string();
             parseServerlistRequest(boost::asio::ip::udp::endpoint(boost::asio::ip::address().from_string(address), port));
@@ -111,9 +109,9 @@ void Server::Update()
 
 void Server::parseMessageType(Packet& packet)
 {
-    // Pop packetSize, sequenceNumber and packetsInSequence.
+    // Pop packetSize which is used by TCP Client to
     // create a packet of the correct size
-    popNetworkSegmentOfHeader(packet);
+    packet.ReadPrimitive<int>();
 
     int messageType = packet.ReadPrimitive<int>(); // Read what type off message was sent from server
     // Read packet ID 
@@ -164,7 +162,10 @@ void Server::reliableBroadcast(Packet& packet)
 
 void Server::unreliableBroadcast(Packet& packet)
 {
-   m_Unreliable.SendToConnectedPlayers(packet, m_ConnectedPlayers);
+    for (auto& kv : m_ConnectedPlayers) {
+        packet.ChangePacketID(kv.second.PacketID);
+        //        m_Unreliable.Send(packet, kv.second);
+    }
 }
 
 // Send snapshot fields
@@ -173,8 +174,7 @@ void Server::sendSnapshot()
     Packet packet(MessageType::Snapshot);
     addInputCommandsToPacket(packet);
     addPlayersToPacket(packet, EntityID_Invalid);
-    //addChildrenToPacket(packet, EntityID_Invalid);
-    unreliableBroadcast(packet);
+    reliableBroadcast(packet);
 }
 
 void Server::addInputCommandsToPacket(Packet& packet)
@@ -299,6 +299,8 @@ void Server::sendPing()
     reliableBroadcast(packet);
 }
 
+
+
 void Server::checkForTimeOuts()
 {
     double startPing = 1000 * m_StartPingTime
@@ -315,35 +317,38 @@ void Server::checkForTimeOuts()
             }
         }
     }
-    for (int i = playersToRemove.size() - 1; i >= 0; i--) {
+    for (size_t i = 0; i < playersToRemove.size(); i++) {
         disconnect(playersToRemove.at(i));
     }
 }
 
-void Server::parseUDPConnect(Packet & packet)
-{
-    //Pop packetSize, sequenceNumber and packetsInSequence.
-    popNetworkSegmentOfHeader(packet);
-    int messageType = packet.ReadPrimitive<int>();
-    // Read packet ID 
-    m_PreviousPacketID = m_PacketID;    // Set previous packet id
-    m_PacketID = packet.ReadPrimitive<int>(); //Read new packet id
-    // parse player id and other stuff
-    PlayerID playerID = packet.ReadPrimitive<int>();
-    boost::asio::ip::udp::endpoint endpoint(m_Address, m_Port);
-    m_ConnectedPlayers.at(playerID).Endpoint = endpoint;
-    LOG_INFO("parseUDPConnect: Spectator \"%s\" connected on IP: %s", m_ConnectedPlayers.at(playerID).Name.c_str(), m_ConnectedPlayers.at(playerID).Endpoint.address().to_string().c_str());
-    // Send a message to the player that connected
-    Packet connnectPacket(MessageType::Connect, m_ConnectedPlayers.at(playerID).PacketID);
-    m_Unreliable.Send(connnectPacket);
-    LOG_INFO("UDP Connect sent to client");
-}
+//void Server::parseUDPConnect(Packet & packet)
+//{
+//    // Pop size of message int
+//    packet.ReadPrimitive<int>();
+//    int messageType = packet.ReadPrimitive<int>();
+//    // Read packet ID 
+//    m_PreviousPacketID = m_PacketID;    // Set previous packet id
+//    m_PacketID = packet.ReadPrimitive<int>(); //Read new packet id
+//    // parse player id and other stuff
+//    PlayerID playerID = packet.ReadPrimitive<int>();
+//    if (!EntityWrapper(m_World, playerID).Valid()) {
+//
+//    }
+//    // Do something here?
+//    boost::asio::ip::udp::endpoint endpoint(m_Address, m_Port);
+//    m_ConnectedPlayers.at(playerID).Endpoint = endpoint;
+//    LOG_INFO("parseUDPConnect: Spectator \"%s\" connected on IP: %s", m_ConnectedPlayers.at(playerID).Name.c_str(), m_ConnectedPlayers.at(playerID).Endpoint.address().to_string().c_str());
+//    // Send a message to the player that connected
+//    Packet connnectPacket(MessageType::Connect, m_ConnectedPlayers.at(playerID).PacketID);
+//    m_Unreliable.Send(connnectPacket);
+//    LOG_INFO("UDP Connect sent to client");
+//}
 
 void Server::parseTCPConnect(Packet & packet)
 {
-    // Pop packetSize, sequenceNumber and packetsInSequence.
-    popNetworkSegmentOfHeader(packet);
-
+    // Pop size of message int
+    packet.ReadPrimitive<int>();
     int messageType = packet.ReadPrimitive<int>();
     // Read packet ID 
     m_PreviousPacketID = m_PacketID;    // Set previous packet id
@@ -351,9 +356,9 @@ void Server::parseTCPConnect(Packet & packet)
 
     LOG_INFO("Parsing connections");
     // Check if player is already connected
+    // Ska vara till lagd i TCPServer receive
     PlayerID playerID = getPlayerIDFromEndpoint();
     if (playerID == -1) {
-        LOG_INFO("Server::parseTCPConnect: Not connected");
         return;
     }
     // Create a new player
@@ -376,7 +381,7 @@ void Server::parseTCPConnect(Packet & packet)
     Packet connnectPacket(MessageType::Connect, m_ConnectedPlayers.at(playerID).PacketID);
     // Write playerID to packet
     connnectPacket.WritePrimitive(playerID);
-    m_Reliable.Send(connnectPacket, m_ConnectedPlayers.at(playerID));
+    m_Reliable.Send(connnectPacket);
 
     Packet firstSnapshot(MessageType::Snapshot);
     addInputCommandsToPacket(firstSnapshot);
@@ -663,4 +668,4 @@ PlayerID Server::getPlayerIDFromEntityID(EntityID entityID)
         }
     }
     return -1;
-}
+}

src/Engine/Network/TCPClient.cpp

@@ -3,14 +3,25 @@
 using namespace boost::asio::ip;
 
 TCPClient::TCPClient()
-{ }
+{
+}
 
 TCPClient::~TCPClient()
-{ }
+{
+}
 
 bool TCPClient::Connect(std::string playerName, std::string address, int port)
 {
-    if (!m_Socket) {
+    if (m_Socket) {
+        if (m_IsConnected) {
+            Packet packet(MessageType::Connect, m_SendPacketID);
+            packet.WriteString(playerName);
+            Send(packet);
+            LOG_INFO("Connect message sent again!");
+        }
+        return true;
+    }
+    else if (!m_IsConnected) {
         boost::system::error_code error = boost::asio::error::host_not_found;
         m_Endpoint = tcp::endpoint(boost::asio::ip::address::from_string(address), port);
         m_Socket = std::unique_ptr<tcp::socket>(new tcp::socket(m_IOService));
@@ -25,7 +36,9 @@ bool TCPClient::Connect(std::string playerName, std::string address, int port)
             Send(packet);
             LOG_INFO("Connect message sent!");
             return true;
-        } else { // If error
+        }
+        // If error
+        else {
             m_Socket->close();
             m_Socket = nullptr;
             return false;
@@ -34,10 +47,14 @@ bool TCPClient::Connect(std::string playerName, std::string address, int port)
 }
 
 void TCPClient::Disconnect()
-{
+{ 
+    if (!m_IsConnected) {
+        return;
+    }
     m_Socket->shutdown(boost::asio::ip::tcp::socket::shutdown_both);
     m_Socket->close();
     m_Socket = nullptr;
+    m_IsConnected = false;
 }
 
 void TCPClient::Receive(Packet& packet)
@@ -49,7 +66,7 @@ void TCPClient::Receive(Packet& packet)
 }
 
 size_t TCPClient::readBuffer()
-{
+{ 
     if (!m_Socket) {
         return 0;
     }
@@ -75,7 +92,7 @@ size_t TCPClient::readBuffer()
     while (sizeOfPacket > bytesReceived) {
         // Read the rest of the message
         bytesReceived += m_Socket->read_some(boost
-            ::asio::buffer((void*)(m_ReadBuffer + bytesReceived), sizeOfPacket - bytesReceived),
+            ::asio::buffer((void*)(m_ReadBuffer), sizeOfPacket - bytesReceived),
             error);
         if (error) {
             //LOG_ERROR("receive: %s", error.message().c_str());

src/Engine/Network/TCPServer.cpp

@@ -48,7 +48,6 @@ void TCPServer::Send(Packet & packet, PlayerDefinition & playerDefinition)
 {
     packet.UpdateSize();
     try {
-        // Crashed once TCPSocket was NULL
         int bytesSent = playerDefinition.TCPSocket->send(
             boost::asio::buffer(packet.Data(), packet.Size()),
             0);

src/Engine/Network/UDPClient.cpp

@@ -1,13 +1,14 @@
 #include "Network/UDPClient.h"
-#include "boost/asio/basic_datagram_socket.hpp"
 
 using namespace boost::asio::ip;
 
 UDPClient::UDPClient()
-{ }
+{ 
+}
 
 UDPClient::~UDPClient()
-{ }
+{ 
+}
 
 bool UDPClient::Connect(std::string playerName, std::string address, int port)
 {
@@ -17,35 +18,22 @@ bool UDPClient::Connect(std::string playerName, std::string address, int port)
     m_ReceiverEndpoint = udp::endpoint(boost::asio::ip::address().from_string(address), port);
     m_Socket = boost::shared_ptr<boost::asio::ip::udp::socket>(new boost::asio::ip::udp::socket(m_IOService));
     m_Socket->open(boost::asio::ip::udp::v4());
-    boost::asio::socket_base::receive_buffer_size option(m_SizeOfSocketBuffer);
-    m_Socket->set_option(option);
     return true;
 }
 
 void UDPClient::Disconnect()
 {
-    m_Socket->shutdown(boost::asio::ip::tcp::socket::shutdown_both);
-    m_Socket->close();
-    m_Socket = nullptr;
 
-    m_LastReceivedSnapshotGroup = 0;
-    m_PacketSegmentMap.clear();
-    PacketID m_SendPacketID = 0;
 }
 
 void UDPClient::Receive(Packet& packet)
 {
     int bytesRead = readBuffer();
-    if (bytesRead > 0) {
+    if (bytesRead > 0) { 
         packet.ReconstructFromData(m_ReadBuffer, bytesRead);
     }
 }
 
-void UDPClient::ReceivePackets()
-{
-    readPartOfPacket();
-}
-
 int UDPClient::readBuffer()
 {
     if (!m_Socket) {
@@ -53,9 +41,9 @@ int UDPClient::readBuffer()
     }
     boost::system::error_code error;
     // Read size of packet
-    m_Socket->receive(boost
+     m_Socket->receive(boost
         ::asio::buffer((void*)m_ReadBuffer, sizeof(int)),
-        boost::asio::ip::udp::socket::message_peek, error);
+         boost::asio::ip::udp::socket::message_peek, error);
     int sizeOfPacket = 0;
     memcpy(&sizeOfPacket, m_ReadBuffer, sizeof(int));
     if (sizeOfPacket > m_Socket->available()) {
@@ -84,72 +72,6 @@ int UDPClient::readBuffer()
     return bytesReceived;
 }
 
-void UDPClient::readPartOfPacket()
-{
-    if (!m_Socket) {
-        return;
-    }
-    boost::system::error_code error;
-    // Peek header
-    m_Socket->receive(boost
-        ::asio::buffer((void*)m_ReadBuffer, 5 * sizeof(int)),
-        boost::asio::ip::udp::socket::message_peek, error);
-
-    int sizeOfPacket = 0;
-    memcpy(&sizeOfPacket, m_ReadBuffer, sizeof(int));
-    if (sizeOfPacket == 0) {
-        return;
-    }
-    int packetGroup = *reinterpret_cast<int*>(m_ReadBuffer + sizeof(int));
-    int packetGroupIndex = *reinterpret_cast<int*>(m_ReadBuffer + 2 * sizeof(int));
-    int packetGroupSize = *reinterpret_cast<int*>(m_ReadBuffer + 3 * sizeof(int));
-    //LOG_INFO("Packet group: %i. Group index: %i. Group size: %i. Packet size: %i.", packetGroup, packetGroupIndex, packetGroupSize, sizeOfPacket);
-    if (sizeOfPacket > m_Socket->available()) {
-        LOG_WARNING("UDPClient::readBuffer(): We haven't got the whole packet yet.");
-        // return;
-    }
-    // if the buffer is to small increase the size of it
-    boost::shared_ptr<char> packetData(new char[sizeOfPacket]);
-
-    // Read the message
-    size_t bytesReceived = m_Socket->receive_from(boost
-        ::asio::buffer((void*)(packetData.get()),
-            sizeOfPacket),
-        m_ReceiverEndpoint, 0, error);
-    if (error) {
-        LOG_ERROR("UDPClient::readPartOfPacket: %s", error.message().c_str());
-    }
-    // Might want to do this earlier when i figure out a good way to 
-    // remove data from network buffer.
-    if (hasReceivedPacket(packetGroup, packetGroupIndex)) {
-        return;
-    }
-    // If group exists
-    PacketMap::iterator it;
-    it = m_PacketSegmentMap.find(packetGroup);
-    if (it != m_PacketSegmentMap.end()) {
-        it->second.push_back(std::make_pair(packetGroupIndex, std::move(packetData)));
-    } else { // Create group and add element
-        m_PacketSegmentMap[packetGroup].push_back(std::make_pair(packetGroupIndex, std::move(packetData)));
-    }
-    return;
-}
-
-bool UDPClient::hasReceivedPacket(int packetGroup, int groupIndex)
-{
-    PacketMap::iterator it;
-    it = m_PacketSegmentMap.find(packetGroup);
-    if (it != m_PacketSegmentMap.end()) {
-        const std::vector<std::pair<int, boost::shared_ptr<char>>>& loopPacketGroup = it->second;
-        for (size_t i = 0; i < loopPacketGroup.size(); i++) {
-            if (loopPacketGroup.at(i).first == groupIndex) {
-                return true;
-            }
-        }
-    }
-    return false;
-}
-
 void UDPClient::Send(Packet& packet)
 {
     packet.UpdateSize();
@@ -157,7 +79,7 @@ void UDPClient::Send(Packet& packet)
         packet.Data(),
         packet.Size()),
         m_ReceiverEndpoint, 0);
-}
+} 
 
 void UDPClient::Broadcast(Packet& packet, int port)
 {
@@ -173,55 +95,8 @@ void UDPClient::Broadcast(Packet& packet, int port)
 
 bool UDPClient::IsSocketAvailable()
 {
-    if (!m_Socket) {
+    if (!m_Socket) { 
         return false;
     }
     return m_Socket->available();
-}
-
-bool UDPClient::GetNextPacket(Packet & packet)
-{
-    // A duplicate packet should not be present in the vector!
-    // Soo we will assume that this is true and only look if size
-    // of vector is correct.
-    PacketMap::iterator it = m_PacketSegmentMap.begin();
-    while (it != m_PacketSegmentMap.end()) {
-        // pair(Group index, packetData)
-        std::vector<std::pair<int, boost::shared_ptr<char>>>& currentVector = it->second;
-        Packet headerInfoPacket(currentVector.at(0).second.get(), packet.HeaderSize());
-        int groupSize = headerInfoPacket.GroupSize();
-        //LOG_INFO("UDPClient::GetNextPacket: Packet group : %i.Group index : %i.Group size : %i. lastReceivedSnapshotGroup: %i. MessageType(Ples 4): %i", headerInfoPacket.Group(), headerInfoPacket.GroupIndex(), groupSize, lastReceivedSnapshotGroup, headerInfoPacket.GetMessageType());
-        //LOG_INFO("UDPClient::GetNextPacket: Packet group : %i.lastReceivedSnapshotGroup: %i. MessageType(Ples 4): %i", headerInfoPacket.Group(), lastReceivedSnapshotGroup, headerInfoPacket.GetMessageType());
-        int mapSize = m_PacketSegmentMap.size();
-        if (mapSize > 5) {
-            it = m_PacketSegmentMap.erase(it);
-            LOG_INFO("The map is increasing in size, size is %i", mapSize);
-            continue;
-        }
-        if (headerInfoPacket.GetMessageType() == MessageType::Snapshot && m_LastReceivedSnapshotGroup > headerInfoPacket.Group()) {
-            it = m_PacketSegmentMap.erase(it);
-            continue;
-            //LOG_INFO("Deleted old entry");
-        }
-        if (currentVector.size() == groupSize) {
-            std::sort(currentVector.begin(), currentVector.end());
-            // Add the first packet in vector
-            packet.ReconstructFromData(currentVector.at(0).second.get(), packet.HeaderSize());
-            // Add the rest of the packets.
-            int sizeOfData = 0;
-            for (auto& packetSegment : currentVector) {
-                memcpy(&sizeOfData, packetSegment.second.get(), sizeof(int));
-                packet.WriteData(packetSegment.second.get() + packet.HeaderSize(), sizeOfData - packet.HeaderSize());
-            }
-            if (headerInfoPacket.GetMessageType() == MessageType::Snapshot) {
-                m_LastReceivedSnapshotGroup = packet.Group();
-            }
-            // No need to get next it as we are returning.
-            m_PacketSegmentMap.erase(it);
-            return true;
-        } else {
-            ++it;
-        }
-    }
-    return false;
-}
+}

src/Engine/Network/UDPServer.cpp

@@ -12,110 +12,34 @@ UDPServer::UDPServer(int port)
 
 UDPServer::~UDPServer()
 { }
-// TODO: Fix correct groups
-void UDPServer::Send(Packet& packet, PlayerDefinition& playerDefinition)
+
+void UDPServer::Send(Packet& packet, PlayerDefinition & playerDefinition)
 {
     packet.UpdateSize();
     try {
-        // Remove header from packet.
-        packet.ReadData(packet.HeaderSize());
-        int totalBytesSent = 0;
-        int groupIndex = 1;
-        int groupSize = std::ceil((float)packet.Size() / MAXPACKETSIZE);
-        int packetDataSent = 0;
-        int packetDataSize = packet.Size() - packet.HeaderSize();
-
-        while (packetDataSize > packetDataSent) {
-            Packet splitPacket(packet.GetMessageType(), playerDefinition.PacketID);
-            splitPacket.ChangeGroupIndex(groupIndex);
-            splitPacket.ChangeGroupSize(groupSize);
-            splitPacket.ChangeGroup(playerDefinition.PacketGroup);
-            int amountToSend = packetDataSize - packetDataSent;
-            if (amountToSend > MAXPACKETSIZE) {
-                amountToSend = MAXPACKETSIZE;
-            }
-            splitPacket.WriteData(packet.ReadData(amountToSend), amountToSend);
-            splitPacket.UpdateSize();
-            // Remove header size from bytes sent soo that we only
-            // count data in the packet
-            int bytesSent = 0;
-            bytesSent = m_Socket->send_to(
-                boost::asio::buffer(splitPacket.Data(), splitPacket.Size()),
-                playerDefinition.Endpoint,
-                0);
-            packetDataSent += bytesSent - splitPacket.HeaderSize();
-            totalBytesSent += bytesSent;
-            //LOG_INFO("bytesSent size %i, groupIndex: %i. Number of packets: %i", bytesSent, sequenceNumber, totalMessages);
-            ++groupIndex;
-        }
-        playerDefinition.PacketGroup++;
+        int bytesSent = m_Socket->send_to(
+            boost::asio::buffer(packet.Data(), packet.Size()),
+            playerDefinition.Endpoint,
+            0);
+        LOG_INFO("Size of packet is %i", bytesSent);
     } catch (const boost::system::system_error& e) {
         LOG_INFO(e.what());
         // TODO: Clean up invalid endpoints out of m_ConnectedPlayers later
         playerDefinition.Endpoint = boost::asio::ip::udp::endpoint();
     }
+
 }
-
-void UDPServer::SendToConnectedPlayers(Packet& packet, std::map<PlayerID, PlayerDefinition>& playersTosendTo)
-{
-    packet.UpdateSize();
-    // Remove header from packet.
-    packet.ReadData(packet.HeaderSize());
-    int totalBytesSent = 0;
-    int groupIndex = 1;
-    int groupSize = std::ceil((float)packet.Size() / MAXPACKETSIZE);
-    int packetDataSent = 0;
-    int packetDataSize = packet.Size() - packet.HeaderSize();
-
-    while (packetDataSize > packetDataSent) {
-        Packet splitPacket(packet.GetMessageType());
-        splitPacket.ChangeGroupIndex(groupIndex);
-        splitPacket.ChangeGroupSize(groupSize);
-        int amountToSend = packetDataSize - packetDataSent;
-        if (amountToSend > MAXPACKETSIZE) {
-            amountToSend = MAXPACKETSIZE;
-        }
-        splitPacket.WriteData(packet.ReadData(amountToSend), amountToSend);
-        splitPacket.UpdateSize();
-        // Remove header size from bytes sent soo that we only
-        // count data in the packet
-        int bytesSent = 0;
-        for (auto& kv : playersTosendTo) {
-            try {
-                splitPacket.ChangeGroup(kv.second.PacketGroup);
-                bytesSent = m_Socket->send_to(
-                    boost::asio::buffer(splitPacket.Data(), splitPacket.Size()),
-                    kv.second.Endpoint,
-                    0);
-                // LOG_INFO("bytesSent: %i", bytesSent);
-            } catch (const boost::system::system_error& e) {
-                LOG_INFO("UDPServer::SendToConnectedPlayers: Disconnected client. %s", e.what());
-                // TODO: Clean up invalid endpoints out of m_ConnectedPlayers later
-                kv.second.Endpoint = boost::asio::ip::udp::endpoint();
-            }
-        }
-        packetDataSent += splitPacket.Size() - splitPacket.HeaderSize();
-        totalBytesSent += splitPacket.Size();
-
-        //LOG_INFO("bytesSent size %i, groupIndex: %i. Number of packets: %i", bytesSent, sequenceNumber, totalMessages);
-        ++groupIndex;
-    }
-    for (auto& kv : playersTosendTo) {
-        kv.second.PacketGroup++;
-    }
-}
-
 // Send back to endpoint of received packet
 void UDPServer::Send(Packet & packet)
 {
     packet.UpdateSize();
-    size_t bytesSent = m_Socket->send_to(
+     size_t bytesSent = m_Socket->send_to(
         boost::asio::buffer(
             packet.Data(),
             packet.Size()),
         m_ReceiverEndpoint,
         0);
-    //LOG_INFO("Size of packet is %i", bytesSent);
+     LOG_INFO("Size of packet is %i", bytesSent);
 }
 
 // Broadcasting respond specific logic
@@ -128,7 +52,7 @@ void UDPServer::Send(Packet & packet, boost::asio::ip::udp::endpoint endpoint)
             packet.Size()),
         endpoint,
         0);
-    //LOG_INFO("Size of packet is %i", bytesSent);
+    LOG_INFO("Size of packet is %i", bytesSent);
 }
 
 // Broadcasting
@@ -140,7 +64,7 @@ void UDPServer::Broadcast(Packet & packet, int port)
         boost::asio::buffer(
             packet.Data(),
             packet.Size()),
-        boost::asio::ip::udp::endpoint(boost::asio::ip::address_v4().broadcast(), port),
+        boost::asio::ip::udp::endpoint(boost::asio::ip::address_v4().broadcast(),port),
         0);
     m_Socket->set_option(boost::asio::socket_base::broadcast(false));
 }
@@ -167,7 +91,7 @@ int UDPServer::readBuffer()
     int addasdasd = m_Socket->available();
     boost::system::error_code error;
     // Read size of packet
-    m_Socket->receive_from(boost
+     m_Socket->receive_from(boost
         ::asio::buffer((void*)m_ReadBuffer, sizeof(int)),
         m_ReceiverEndpoint, boost::asio::ip::udp::socket::message_peek, error);
     unsigned int sizeOfPacket = 0;
@@ -190,13 +114,13 @@ int UDPServer::readBuffer()
         ::asio::buffer((void*)(m_ReadBuffer),
             sizeOfPacket),
         m_ReceiverEndpoint, 0, error);
-    if (error) {
-        //LOG_ERROR("receive: %s", error.message().c_str());
-    }
-    if (sizeOfPacket > 1000000)
-        LOG_WARNING("The packets received are bigger than 1MB");
+        if (error) {
+            //LOG_ERROR("receive: %s", error.message().c_str());
+        }
+        if (sizeOfPacket > 1000000)
+            LOG_WARNING("The packets received are bigger than 1MB");
 
-    return bytesReceived;
+        return bytesReceived;
 }
 
 void UDPServer::AcceptNewConnections(int& nextPlayerID, std::map<PlayerID, PlayerDefinition>& connectedPlayers)